search

sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

44 fix members for real #44

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

Handles 2 issues that were preventing Assignment dropdowns from being populated correctly on item cards.

Where should the reviewer start?

  1. FilterActions.init was rewritten to match the other Flux-y things in the app: async stuff happens in the action, and the store is updated once those are done. Accompanying changes in the FiltersStore and ProductStore because the method signature changed
  2. Enforce that members is always passed down to item cards. We had missed this when sprints were added, so this prop is now required to render a card.

    Background context

@mikekauffman's previous fix for this was on the right track, but ultimately there was a race condition that was preventing things from re-rendering everywhere when the members and tags data came back.

How should it be manually tested?

Assignment should work, like, everywhere.

Related tickets

https://sprint.ly/product/31528/item/44

GIF

giphy-3

phoenixbox commented 9 years ago

@wookiehangover looks good Although there seems to be a DOM node selector issue happening with the assignment select component.

image

Happens when the member assignment dropdown is closed