search

sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

Fix Console Warnings #59

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

Adds a bunch of missing key properties that were surfacing as console warnings.

Where should the reviewer start?

This was mostly in the mobile menu code that landed last week; a couple of spots were using [].concat to assemble content for components, but didn't provide key props for everything.

Background context

Even when you're outside of a loop, apparently you must key array properties.

There's also a need to share / reuse some of this code, but that can get addressed another day.

phoenixbox commented 9 years ago

:( my bad, this is definitely one of things I have seen and consistently said "oh Ill swing back and get them all at the end" and then I never did it

sorry :-1: