Pulls off the band aid and updates a bunch of dependencies, including:
react
react-router
react-*
sprintly-data
sprintly-ui
gulp & friends
Also,
adds a .eslintrc file with an eyeline to consistent linting in the future
fixes some data flow issues that were a contributing factor to filters weirdness that @phoenixbox found a few weeks ago
removes deprecated calls to classSet in favor of className standalone dependency
drops a bunch of unused or deprecated dependencies
works with npm v3! (flat folder structure in node_modules, faster installs, progress bars, etc) edit: babel / babelify is holding us back on this now
Where should the reviewer start?
This is a big one.
Nearly all of the changes in app/actions are from linting and can be ignored
views/components/filters has the most substantial changes:
sprintly-ui selector replaced with react-select
react-typeahead replaced with our home grown TagInput
Upstream changes were needed in some deps, which are now published on npm as scoped modules (their names start with @sprintly
Background context?
We've waited just long enough on this one: we avoided big-time API thrash with react-router, dropped or rewrote other dependencies that had fallen behind, and hopefully made the next react version bump a bit easier on ourselves. I obviously also performed some shotgun surgery on a few things along the way.
What does it do?
Pulls off the band aid and updates a bunch of dependencies, including:
Also,
.eslintrcfile with an eyeline to consistent linting in the futureclassSetin favor ofclassNamestandalone dependencyworks with npm v3! (flat folder structure inedit: babel / babelify is holding us back on this nownode_modules, faster installs, progress bars, etc)Where should the reviewer start?
This is a big one.
app/actionsare from linting and can be ignoredviews/components/filtershas the most substantial changes:@sprintlyBackground context?
We've waited just long enough on this one: we avoided big-time API thrash with react-router, dropped or rewrote other dependencies that had fallen behind, and hopefully made the next react version bump a bit easier on ourselves. I obviously also performed some shotgun surgery on a few things along the way.
GIF