sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

Reordering #7

Closed wookiehangover closed 9 years ago

wookiehangover commented 9 years ago

What does it do?

Wires up item reordering to the new API endpoint. Depends on sprintly/sprintly-data#15

Where should the reviewer start?

app/stores/product-store.js

Other things to note:

Use npm link to use the branch from sprintly/sprintly#15 if it's not merged yet. Then try out the "resort" buttons.

Screenshots

Reordering is disabled unless you sort by priority.

screen shot 2015-04-01 at 4 27 17 pm

GIF?

grip-ball

wookiehangover commented 9 years ago

Just realized the tests are going to fail until the PR in sprintly-data lands :rage4:

florapdx commented 9 years ago

screen shot 2015-04-02 at 12 56 16 pm

wookiehangover commented 9 years ago

@florapdx pretty confident that you were seeing a build issue / had the wrong version of sprintly-data. Pushed a new release on npm and the tests are green (which need item.resort to exist).

florapdx commented 9 years ago

Oh good. Yeah, I don't know what's up with that. I'm pretty sure that I set everything up correctly at least 2x, but I'm glad the error wasn't real :)

justinabrahms commented 9 years ago

We have an uncaught error if you attempt to "move up" an item that is at the top. Should probably catch that error. I'd guess the same happens if "move down" on the last item.

justinabrahms commented 9 years ago

Looks fine to me otherwise. Would be nice if make also build our CSS, but non-blocker.