Closed wookiehangover closed 9 years ago
Just realized the tests are going to fail until the PR in sprintly-data lands :rage4:
@florapdx pretty confident that you were seeing a build issue / had the wrong version of sprintly-data. Pushed a new release on npm and the tests are green (which need item.resort
to exist).
Oh good. Yeah, I don't know what's up with that. I'm pretty sure that I set everything up correctly at least 2x, but I'm glad the error wasn't real :)
We have an uncaught error if you attempt to "move up" an item that is at the top. Should probably catch that error. I'd guess the same happens if "move down" on the last item.
Looks fine to me otherwise. Would be nice if make
also build our CSS, but non-blocker.
What does it do?
Wires up item reordering to the new API endpoint. Depends on sprintly/sprintly-data#15
Where should the reviewer start?
app/stores/product-store.js
Other things to note:
How should this be manually tested?
Use
npm link
to use the branch from sprintly/sprintly#15 if it's not merged yet. Then try out the "resort" buttons.Screenshots
Reordering is disabled unless you sort by priority.
GIF?