sprintly / sprintly-kanban

A Kanban Board for Sprintly
https://kanban.sprint.ly
ISC License
494 stars 82 forks source link

Add item port #73

Closed phoenixbox closed 9 years ago

phoenixbox commented 9 years ago

What's this PR do?

Moves the add item functionality into the drawer design pattern we followed for the item detail page Refactors multiple subitem components used across item card and add item into two ./component/subitems&subitem

Where should the reviewer start?

pages/add-item

How should this be manually tested?

Open the app and visit /add-item Under a story confirm that you can add subitems and remove them Hit create and see that the subitems get batch created after

Background Context

I updated the event change emission signature on the product store to accept a type && record param so that the view component could look for passed arguments within its _onChange function. Open to other suggestions/patterns. I failed to be able to find a way to return a reference to the newly created item via the Dispatcher otherwise.

I made the subitems component more generic so that its less context aware and can be repurposed across the

No attachment support yet.

Screenshots (if appropriate)

image

image

phoenixbox commented 9 years ago

@wookiehangover caught an incorrect reference to the parent item which was breaking things

Should be good to push to a staging branch now :+1: