spritsail / fivem

FiveM GTA modded multiplayer server
https://github.com/citizenfx/fivem
115 stars 141 forks source link

Update for onesync population fix #31

Closed JoeSzymkowiczFiveM closed 3 years ago

JoeSzymkowiczFiveM commented 3 years ago

To fix ped population not appearing when onesync infinity is enabled.

As a side note, reading more about onesync and all it's lovely variations and parameter that need to be enabled/disabled in certain scenarios, I'm not sure if hardcoding these exec arguments is a good long-term plan. I would make the case a docker argument that lets the user put in whatever text they need might be a good catch-all, instead of trying to accomplish every scenario, every time the fivem devs add another exec command.

Example, if I could just add "-e CUSTOM_ARGS='+set onesync on +set onesync_population' " , I would be able to adjust my server settings without a modification to the image. Just a thought.

frebib commented 3 years ago

I always thought you could pass additional args but looking at the entrypoint script I guess it's not possible. I suppose dropping the CONFIG_ARGS= line should allow doing that.

Can you pass additional args with the docker CMD? e.g. docker run .. spritsail/fivem +whatever? That should probably work.

PR lgtm