search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Adds exclude option to abbot. #101

Closed fairbanksg closed 11 years ago

fairbanksg commented 11 years ago

The exclude option is a list of directories in the target that should not be included in builds.

publickeating commented 11 years ago

Can we turn this into an improvement on Whitelist and Blacklist so that we can use a one-liner Blacklist inside of SproutCore to keep PhantomJS totally out? Also, do you know what the heck :accept is all about?

dcporter commented 11 years ago

My thought was that it would be nice to have a parallel feature inside Buildfile, so everything was in one place. Also improving Whitelist/Blacklist would be fine, but the discoverability on that feature is ... nil.

fairbanksg commented 11 years ago

I agree with @dcporter. I feel like they should be separate because the intentions are different. Blacklist is intended to allow for a user to exclude the pieces of SC they are not using from the build, to slim it down. Having an exclude option is saying that the author of the framework indicated these directories should not be in the build. In addition, having it in the buildfile provides the flexibility to change it based on build mode.

publickeating commented 11 years ago

Sure, I still think it would be nice to have :whitelist and :blacklist per target in the Buildfile, but I get your point about :exclude.

So merge this in as is?

fairbanksg commented 11 years ago

As far as I can tell, the Accept file is the old, deprecated way of doing Whitelist/Blacklist. It is a single file that has both ALLOW and DENY entries. Relevant code is in lib/buildtasks/helpers/file_rule_list.rb (the read method).

fairbanksg commented 11 years ago

:+1: