Updates YUICompressor to version 2.4.8

sproutcore / abbot

SproutCore Build Tools [deprecated]

http://www.sproutcore.com

88 stars 44 forks source link

Updates YUICompressor to version 2.4.8 #106

Closed nicolasbadia closed 10 years ago

nicolasbadia commented 10 years ago

YUI Compressor 2.4.8

Fix "important" and conditional comment processing
Fix a bug in the support for JS 1.7 style getters/setters
Better compliance and results in CSS compression (@danbeam, @faisalman, @killsaw, @ademey)
Now minifies "border-left" in CSS (@sbertrang)
Include filename in warning and error output (@danielbeardsley)
Many improvements to parameter parsing and batch modes (@bmouw, @bandesz, @ryansully)
Include jQuery as part of our test suite (@apm)
Trim trailing commas where possible (@nlalevee)

nicolasbadia commented 10 years ago

Any reason this is not merge yet ? YUI Compressor 2.4.7 is failing to minify PDF.js (I've added it as an SC module). Version 2.4.8 is doing fine.

publickeating commented 10 years ago

Nope, just that I hadn't looked at the Abbot list in a while. Merging.

nicolasbadia commented 10 years ago

Feel free to revert. It seems 2.4.8 has bigger issues than 2.4.7.

I personally moved to closure compiler. It is for more slower but I have no issue with it and it do a better compression. I will not submit a PR for this since I know nothing about ruby but here is the command line I use (just in case) :

command = %{java -jar "#{SC.js_jar}" --warning_level=QUIET --js "#{p}" --language_in ECMASCRIPT5 --js_output_file "#{p}.tmp" 2>&1; mv #{p}.tmp #{p} }