search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Spriting does not work on Windows #78

Closed workmanw closed 12 years ago

workmanw commented 12 years ago

After upgrading our Windows developers to master they discovered that spriting was not working on Windows (works fine on Linux and Mac). This is only a problem in dev mode because in release mode the images are inserted into the CSS as base64.

I was able to track the problem to this commit 9bef027ace4611c15f780d4450516103fc0d6985 . This commit was a merge from Apple, it's parent commit 930e57dd88fa531908452aa3d6356575587971ce works correctly.

Unfortunately I'm not a Ruby developer and this was a very large merge so debugging it is taking me a very long time. I would greatly appreciate any assistance with this issue.

Edit: Change the title to reflect my recent findings

workmanw commented 12 years ago

After further research I've narrowed this issue down to this commit : 36213542b76 . However the contents of that commit just turn spriting on by default. It seems as if spiriting in has never worked on Windows.

I went back to SC 1.5 and tried in both dev mode (with sc-server) and release mode (with sc-build) and neither one will produce sprited images. They do actually create the png file and it seems to be around the correct size (92K) however the images them selves are invalid. It seems like maybe it's a chunky_png issue. I'm not really sure at this point.

Does anyone have any thoughts? At this point I've had our windows developers turn off spriting in there build file ( config :all, :use_sprites => false ) and that's a good work around for the time being.

workmanw commented 12 years ago

This issue has been fixed.