search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Ruby 1.8.x compatability fixes #90

Closed wemrysi closed 12 years ago

wemrysi commented 12 years ago

I've made a few minor fixes to abbot that were breaking compatability with Ruby 1.8.x

publickeating commented 12 years ago

Thanks! I will check it out over the weekend.

ChadEubanks commented 12 years ago

Moving abbot to a ruby 1.9.3 and greater environment would be best. 1.8.7 is already becoming unsupported by other major gems in the ruby community. We can ease on boarding new developers by having a clear walkthrough of installing a ruby environment such as: http://pragmaticstudio.com/blog/2010/9/23/install-rails-ruby-mac

wemrysi commented 12 years ago

True, but you'll notice that there are only a few minor syntax changes needed to make abbot compatible with 1.8.7. Given the simplicity of the patch, I don't think it adds any extra maintenance burden.

I'm also not advocating that Sproutcore officially promise support for 1.8.7. I just noticed that the bits that were incompatible were very minor and it didn't take much to fix them (nor are we losing any functionality provided by 1.9.x as a result).

ChadEubanks commented 12 years ago

@wemrysi I agree that your patch has minor fixes that allow a 1.8.7 environment. And I appreciate you taking the time to do so. I still prefer abbot to be a 1.9.3 gem and that we start to move forward from 1.8.7. @publickeating Your call.

dcporter commented 12 years ago

If it's that easy to make abbot ALSO work with the version of ruby that ships with OS X then it's a huge win for newbies. Having to deal with ruby at all -- much less the frustrations of versions (and rvm, and downloading a gcc compiler, and so on) -- is a psychological roadblock to SproutCore adoption by someone who's coming over from a JavaScript world, where the baseline required toolset is a working copy of TextEdit and a browser.

publickeating commented 12 years ago

Thanks a lot, I checked out your changes, ran it on 1.8.7 and 1.9.2 and didn't see any problems.

Merged into master.