search

sproutcore / abbot

SproutCore Build Tools [deprecated]
http://www.sproutcore.com
88 stars 44 forks source link

Handle correctly the UTF8 css files #99

Closed mirion closed 10 years ago

mirion commented 11 years ago

The current version of abbot is not handling correctly the UTF8 css files. This is particularly disturbing when using styles using content: with unicode characters. This patch simply instructs scss to produce UTF8 files, using the @charset="UTF-8" statement on the 1st line of the generated scss files. Probably this operation could be done selectively but involves bigger changes into abbot.

mirion commented 10 years ago

I think that it makes sense to integrate this patch too into 1.10.1. It is quit e basic and I'm using it every day.

publickeating commented 10 years ago

I've looked at this one a bit. I think it makes sense but it would be nice if it was configurable. I'll try to review it again before tomorrow

Sent from my mobile.

On Oct 22, 2013, at 7:36 AM, mirion notifications@github.com wrote:

I think that it makes sense to integrate this patch too into 1.10.1. It is quit e basic and I'm using it every day.

— Reply to this email directly or view it on GitHub.

publickeating commented 10 years ago

I worked on this for a while, but with little success. You can add the @charset to the files manually easily enough and even make it a config option, but when you actually build a project this poses a problem because the files are concatenated into stylesheet-packed.css. I don't think we'll get a solution to this any time soon without some serious deep digging into the build process.