search

sproutcore / build-tools

SproutCore Build Tools
12 stars 7 forks source link

Clean up #55

Closed nicolasbadia closed 9 years ago

mauritslamers commented 9 years ago

I have a few remarks: If we are leaving node v0.10 behind, we don't need watchCounts or keeping track of the paths, as node v0.12 supports recursive. If we are going to drop the fsevents dep (which I think is a good idea), we also better refactor the directory watchers, and just use recursive on the framework directory.

nicolasbadia commented 9 years ago

That's what I started to do until I read the node doc which say that the recursive option is only supported on OS X.

nicolasbadia commented 9 years ago

watchCount is indeed not needed but I wanted to know how many directories were being watch for my project. Since there is no performance impact I thought it may be useful to keep it for future use...

mauritslamers commented 9 years ago

ok, great. Merging...