search

sql-machine-learning / sqlflow

Brings SQL and AI together.
https://sqlflow.org
Apache License 2.0
5.11k stars 701 forks source link

Fix some bugs of Python feature derivation #2999

Closed sneaxiy closed 4 years ago

sneaxiy commented 4 years ago

Address part of https://github.com/sql-machine-learning/sqlflow/issues/2985 .

Make the Python feature derivation be the same as the Go feature derivation.

codecov-io commented 4 years ago

Codecov Report

Merging #2999 into develop will decrease coverage by 0.00%. The diff coverage is 26.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2999      +/-   ##
===========================================
- Coverage    27.73%   27.73%   -0.01%     
===========================================
  Files         4540     4540              
  Lines       703125   703185      +60     
===========================================
+ Hits        195009   195015       +6     
- Misses      507444   507498      +54     
  Partials       672      672
Impacted Files Coverage Δ
go/ir/feature_column.go 20.62% <0.00%> (ø)
python/runtime/step/tensorflow/train.py 22.22% <0.00%> (ø)
python/runtime/feature/derivation.py 86.00% <25.00%> (ø)
python/runtime/local/xgboost_submitter/train.py 92.98% <100.00%> (ø)
...e-packages/aliyunsdkcore/utils/parameter_helper.py 31.57% <0.00%> (-38.43%) :arrow_down:
....6/site-packages/aliyunsdkcore/utils/validation.py 63.63% <0.00%> (-19.70%) :arrow_down:
...s/aliyunsdkcore/endpoint/endpoint_resolver_base.py 50.00% <0.00%> (-2.39%) :arrow_down:
...liyunsdkcore/endpoint/chained_endpoint_resolver.py 25.00% <0.00%> (-2.03%) :arrow_down:
.../site-packages/aliyunsdkcore/http/http_response.py 30.76% <0.00%> (-2.02%) :arrow_down:
...b/python3.6/site-packages/aliyunsdkcore/request.py 33.56% <0.00%> (-0.69%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04aeeab...687aa56. Read the comment docs.