sqlite / sqlite-wasm

SQLite Wasm conveniently wrapped as an ES Module.
605 stars 48 forks source link

Add types for `Sqlite3Worker1Promiser` #76

Closed sameoldlab closed 6 months ago

sameoldlab commented 6 months ago

Progress:

As the methods are very similar to worker1, I'm hoping I can reduce what is specified here and reuse the existing types where possible.

tomayac commented 6 months ago

How does this relate to https://github.com/sqlite/sqlite-wasm/pull/54? Could you maybe join forces?

sameoldlab commented 6 months ago

How does this relate to #54? Could you maybe join forces?

Yes, It's for the same issue. I made my PR against the sqlite:types-improvement branch, so ideally that could get merged to main when everything is complete.

sameoldlab commented 6 months ago

In that case would it make more sense for me to mark this as ready for review now and then track progress in https://github.com/sqlite/sqlite-wasm/pull/54?

tomayac commented 6 months ago

I think so, yes. Please ask someone from #54 for a review, and let's then merge it, so from thereon you can continue working on #54. Thanks!

tomayac commented 6 months ago

Merged, as whatever you have is better than the stub we had in #54. Let's continue the work on #54. Thank you!