Closed sameoldlab closed 6 months ago
How does this relate to https://github.com/sqlite/sqlite-wasm/pull/54? Could you maybe join forces?
How does this relate to #54? Could you maybe join forces?
Yes, It's for the same issue. I made my PR against the sqlite:types-improvement branch, so ideally that could get merged to main when everything is complete.
In that case would it make more sense for me to mark this as ready for review now and then track progress in https://github.com/sqlite/sqlite-wasm/pull/54?
I think so, yes. Please ask someone from #54 for a review, and let's then merge it, so from thereon you can continue working on #54. Thanks!
Merged, as whatever you have is better than the stub we had in #54. Let's continue the work on #54. Thank you!
Progress:
Sqlite3Worker1PromiserConfig
. Not sure what goes in for the args ofgenerateMessageId
Promiser
Methodopen
'sfilename
andvfs
exec
needs to add a full list of arguments, js eqivalent for sqlVALUE
value used in row and bindPromiser
. Described as "// possibly other metadata ..." on sqlite docs. Not sure how stable these are / if they should be documented here.Promiser
response error stack trace arrayAs the methods are very similar to worker1, I'm hoping I can reduce what is specified here and reuse the existing types where possible.