sqlpage / SQLPage

Fast SQL-only data application builder. Automatically build a UI on top of SQL queries.
https://sql-page.com
MIT License
1.66k stars 99 forks source link

Big number change percent doens't show if no description #688

Closed ToniJ123 closed 2 weeks ago

ToniJ123 commented 2 weeks ago

Introduction

Big number change percent doens't show if no description

To Reproduce

select 
    'big_number'          as component,
    6                     as columns,
    'colorfull_dashboard' as id;
select 
    'Vahvuus tällä viikolla' as title,
    87                as value,
    '%'               as unit,
    2                 as change_percent,
    87                as progress_percent,
    ' '             as description,
    'blue'            as progress_color,
    'cyan'   as color;

/*
--Not working solution at the moment
select 
    'big_number'          as component,
    6                     as columns,
    'colorfull_dashboard' as id;
select 
    'Vahvuus tällä viikolla' as title,
    87                as value,
    '%'               as unit,
    2                 as change_percent,
    87                as progress_percent,
    'blue'            as progress_color,
    'cyan'   as color;
*/

Actual behavior

If big number component doesn't have description defined, it will not render change percent, even it would be defined

your error message here

Screenshots

bignumberbug

Expected behavior

I suppose that change percent could be presented without description as well

Version information

Doesn't matter

Additional context

Simple as that

lovasoa commented 2 weeks ago

fixed in 0.31!

ToniJ123 commented 3 days ago

Hi, great that this is fixed now, but is the behaviour of the big number elements still like it should be? Here is an example when the size differs pretty much depending what parameters are used, and one in the middle is now without description field? Also when using all the parameters, it goes straight attached to the next row's big number elements? Is this the intented behaviour?

big_number_layout

Thanks! Keep up the good work! 👍

lovasoa commented 3 days ago

Hi Toni ! Thanks for the feedback ! Can you open separate issues, with a minimal reproduction for each one, to help us track this ?