sqmk / huejay

Philips Hue client for Node.js
MIT License
424 stars 40 forks source link

Add ability to use Philips' remote API #111

Open codetheweb opened 5 years ago

codetheweb commented 5 years ago

This PR adds the ability to use the Remote API that Philips provides, as well as a few small bug fixes.

The Remote API is virtually identical to the local bridge API, which made it very easy to add with minimal changes.

In addition, I fixed a few issues:

Finally, if you're open to it I'd like to add a linter for the sake of consistent code styling (perhaps in a different PR). I have no personal preference for a specific linter, but I use XO for my projects which has sensible defaults.

This is my first time contributing to this project, so please let me know if I need to rework something or I didn't structure it quite right.

sqmk commented 5 years ago

Thanks for the submission.

I'd prefer to go the route of using the strategy pattern and having two classes handling remote and local API calls. Some of your work will be useful for that.