Fixes intent handling and adds sample app, test for it.

square / flow

Name UI states, navigate between them, remember where you've been.

Apache License 2.0

2.79k stars 241 forks source link

Fixes intent handling and adds sample app, test for it. #238

Closed rjrjr closed 7 years ago

rjrjr commented 7 years ago

https://github.com/square/flow/issues/180

rjrjr commented 7 years ago

Test is ugly in one respect: it creates a new instance of the activity. Worth fixing? I suppose I could make the activity single instance, but that's not really required.

rjrjr commented 7 years ago

Ideally we'd test both getting an intent to an existing activity and creating a new activity with an intent, since those code paths are so damn different. Maybe I should make two activities with different manifests.

rjrjr commented 7 years ago

Cool, if I make the activity singleInstance your built in intent handling breaks. Investigating.

rjrjr commented 7 years ago

Fixed, moar tests.

loganj commented 7 years ago

LG!