search

square / spoon

Distributing instrumentation tests to all your Androids.
https://square.github.io/spoon/
Apache License 2.0
2.7k stars 477 forks source link

Spoon#copy causes a buffer overrun #569

Closed AlexBeggs closed 4 years ago

AlexBeggs commented 4 years ago

The Spoon#copy method doesn't take into consideration the amount read into the buffer and writes the entire buffer, not up to the limit of the contents just read causing extra characters to be produced at the end of the file

edenman commented 4 years ago

Did you close the PR because this isn't actually an issue?

AlexBeggs commented 4 years ago

It's an issue for the 1.7.1 tag. It has been corrected in the latest codebase. But that leads me to the question when the next release will occur.

On Fri, Nov 8, 2019, 5:59 PM Eric Denman notifications@github.com wrote:

Did you close the PR because this isn't actually an issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/square/spoon/issues/569?email_source=notifications&email_token=ABCGWAXJQWKIXZZFCSVBELLQSXVOZA5CNFSM4JKLQ7SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTTMFY#issuecomment-552023575, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCGWASP6IGIIVMT5AY6P2DQSXVOZANCNFSM4JKLQ7SA .

edenman commented 4 years ago

Sorry, no estimate on release date