search

src-d / lookout-sdk

SDK for lookout analyzers
Apache License 2.0
4 stars 11 forks source link

Integration tests could also test lookout #51

Closed dpordomingo closed 5 years ago

dpordomingo commented 5 years ago

Since sdk is a lookout dependency, I wonder if it could be tested deeper here. Currently, we only test the example analyzers with lookout-sdk binary (lookout-tool) what might be not enough.

We could try, for example, building lookout-sdk binary (lookout-tool) to ensure the sdk didn't break lookout.

smacker commented 5 years ago

Sorry @dpordomingo I just realized it's not going to work as is.

We lock lookout-sdk version in lookout. So building will always use locked version, not the one in PR.

Maybe we can work around it using some crazy sed or something else but I'm not sure it's a good idea.

smacker commented 5 years ago

@dpordomingo shall we close it?