search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Fix typos dataset generation error: case sensitivity #765

Closed vmarkovtsev closed 5 years ago

vmarkovtsev commented 5 years ago

One month of running 4 machines, 12 cores each - for nothing :cry:

zurk commented 5 years ago

Test failed because of recent changes in modelforge: https://github.com/src-d/modelforge/commit/9e10ff214ad356d4073ebadd6374df961ee88975 because it expects to get each log entry at one line. I can fix it.

zurk commented 5 years ago

@vmarkovtsev https://github.com/src-d/style-analyzer/pull/766, but as I said in the PR description I do not like JSON formatting in case of logging.

vmarkovtsev commented 5 years ago

@irinakhismatullina PTAL https://travis-ci.com/src-d/style-analyzer/jobs/201648869#L4358

irinakhismatullina commented 5 years ago

numpy changed smth: https://github.com/automl/auto-sklearn/issues/667. Should I explicitly fix this argument everywhere, or to restrict the numpy version?

vmarkovtsev commented 5 years ago

As usual, fix it if easy, otherwise pin the version.

vmarkovtsev commented 5 years ago

@zurk The CI has finally passed.