Impulse: tags with emoji or spaces

srid / neuron

Future-proof note-taking and publishing based on Zettelkasten (superseded by Emanote: https://github.com/srid/emanote)

https://neuron.zettel.page

GNU Affero General Public License v3.0

1.51k stars 149 forks source link

Closed gillchristian closed 3 years ago

gillchristian commented 3 years ago

Links to tag search don't work on Impulse when the tag contains emoji or spaces.

Searching directly in Impulse for a tag that includes emoji works. But it doesn't for tags with spaces.

As a side note, links containing emoji, spaces or both do work on Cerveau:

srid commented 3 years ago

Can emojis be used in zettel IDs and filenames?

(Soon enough, tags can only contain exactly what's allowed in zettel ID)

srid commented 3 years ago

Spaces ... we should definitely support.

Might have to allow quotting in the search query (as it gets improved), i.e.: tag:"Foo Bar"

gillchristian commented 3 years ago

Can emojis be used in zettel IDs and filenames?

At least not in file names. So I guess it makes sense they don't work on tags either.

Spaces ... we should definitely support.

Might have to allow quotting in the search query (as it gets improved), i.e.: tag:"Foo Bar"

Should I close this issue and open one specific for spaces? Or is that already under the radar?

srid commented 3 years ago

Yes, spaces will have to get supported as part of #379. Some things to consider:

Inline tags (#foo) may not support spaces.
However, we can "extend" inline tag syntax so that it can support full range of zettel IDs. eg: #[[Foo bar]].
- Basically the syntax is same as for links, but we tack in a # at the beginning.
- This means, we would have three types of links: [[ (cf), [[[ (folge), #[[ (reverse-folge).
  - But the second can be treated as an alias for the third; so in effect, there are only two types.
In YAML metadata, you can already use spaces by quoting, tags: [ "Foo bar"]

EDIT: More thoughts on this at Matrix

gillchristian commented 3 years ago

Yeah, there are several cases to cover to fully support spaces in tags.

Closing this since #379 will cover it.

Will checkout the conversation at Matrix :eyes: