Use filesystem-safe version of movie_name in filesystem-related tasks

srid99 / einthusan-dl

A utility script to download movies from einthusan.tv

37 stars 21 forks source link

Use filesystem-safe version of movie_name in filesystem-related tasks #13

Closed VinnyPutty closed 7 years ago

VinnyPutty commented 8 years ago

Filesystem tasks have been updated to use filesystem-safe version of movie_name when creating output directory and output file (ran into a problem when trying to download a movie with a colon in the title). There are about 15 other commonly illegal characters for filenames, but they do not commonly appear in movie titles so they were not included in order to be succinct.

srid99 commented 7 years ago

@VinnyPutty first of all thanks for the contribution. But unfortunately, it is not possible to merge this PR anymore since this I fixed it part of another issue (https://github.com/srid99/einthusan-dl/commit/10160b33fda9e7e3061743a6efaee34ac353a4a6). It is my mistake that I didn't check this PR earlier, once again sorry for that. I will close this PR.