srl-labs / containerlab

container-based networking labs
https://containerlab.dev
BSD 3-Clause "New" or "Revised" License
1.56k stars 266 forks source link

configure.sh uses wrong values for clab-node-kind and gnmic user/pass #2274

Closed hyposcaler-bot closed 2 weeks ago

hyposcaler-bot commented 2 weeks ago

couple of issues with the containerlab 5-stage Clos topology lab

  1. configure.sh expects clab-node-kind label to be set to srl, but freshly started lab has it set to nokia_srlinux, just need to update configure.sh with new kind name.
dfanshaw@midgard:~/src/containerlab/lab-examples/templated02$ docker ps -f label=clab-node-kind=srl -f label=containerlab=templated02 --format {{.Names}}
dfanshaw@midgard:~/src/containerlab/lab-examples/templated02$ docker ps -f label=clab-node-kind=nokia_srlinux -f label=containerlab=templated02 --format {{.Names}}
clab-templated02-spine3-2
clab-templated02-spine4-2
clab-templated02-spine2-2
clab-templated02-leaf2-4
clab-templated02-spine3-1
clab-templated02-super-spine1
clab-templated02-leaf1-3
clab-templated02-leaf2-2
clab-templated02-leaf3-3
clab-templated02-leaf4-2
clab-templated02-leaf4-1
clab-templated02-leaf1-1
clab-templated02-spine4-1
clab-templated02-leaf4-4
clab-templated02-leaf1-2
clab-templated02-leaf1-4
clab-templated02-spine1-1
clab-templated02-leaf2-1
clab-templated02-leaf3-4
clab-templated02-spine2-1
clab-templated02-leaf2-3
clab-templated02-spine1-2
clab-templated02-leaf3-2
clab-templated02-leaf4-3
clab-templated02-super-spine2
clab-templated02-leaf3-1
dfanshaw@midgard:~/src/containerlab/lab-examples/templated02$
  1. configure.sh also expects user/pass for the gnmi interface to be admin/admin rather than the current default creds.

Suspect same issue will be present for Leaf-spine topology lab

  1. Lab docs should also call out that gnmic and gomplate are dependencies as is done for the Leaf-spine topology lab

have local fixes for PR, will submit PR later.

hyposcaler-bot commented 2 weeks ago

https://github.com/srl-labs/containerlab/pull/2275 cleans up the issues.

hyposcaler-bot commented 2 weeks ago

pr merged, resolving this out.