search

srlabUsask / crhmcode

GNU General Public License v3.0
8 stars 4 forks source link

ClassGlacier_melt_debris_cover_estimate_Mod, ClassGlacier_debris_cover, Classglacier_debris #420

Open loganxingfang opened 2 years ago

loganxingfang commented 2 years ago

I have noticed that there are several modules in crhmcode to handle debris cover glacier. They are:

  1. glacier_debris module, compiled from Classglacier_debris https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/Classglacier_debris.cpp https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/Classglacier_debris.h

There is no matching glacier_debris module in Borland CRHM, so it is not from Borland CRHM source code on GitHub. Somehow it made to crhmcode. Anyway, glacier_debris module contains code out of date and not correct for handling debris cover glacier. The debris cover glacier using Debris Enhanced Temperature-Index (DETI) model by Carenzo et al (2016) is handled properly in glacier module. I request to remove glacier_debris module from new version crhm to reduce confusion for users.

  1. Glacier_debris_cover module, compiled from ClassGlacier_debris_cover https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/waterquality/ClassGlacier_debris_cover.cpp https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/waterquality/ClassGlacier_debris_cover.h

  2. Glacier_melt_debris_cover_estimate_Mod module, compiled from ClassGlacier_melt_debris_cover_estimate_Mod https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/waterquality/ClassGlacier_melt_debris_cover_estimate_Mod.cpp https://github.com/srlabUsask/crhmcode/blob/master/crhmcode/src/modules/waterquality/ClassGlacier_melt_debris_cover_estimate_Mod.h

Both Glacier_debris_cover and Glacier_melt_debris_cover_estimate_Mod modules are from water quality branch, but the codes are out of date and do not look like being used by water quality module. I request to remove Glacier_debris_cover and Glacier_melt_debris_cover_estimate_Mod modules from new version crhm to reduce confusion for users.

jhs507 commented 2 years ago

From a code level standpoint the way to do this will be to move the declarations of the modules in question into the

if (!RELEASE)

branch in NewModules.cpp

It looks like the RELEASE flag is not being set correctly which is a separate issue I will need to address.

loganxingfang commented 2 years ago

From a code level standpoint the way to do this will be to move the declarations of the modules in question into the

if (!RELEASE)

branch in NewModules.cpp

It looks like the RELEASE flag is not being set correctly which is a separate issue I will need to address.

That is correct. Setting them under if (!RELEASE) would do it.