srophe / britishLibrary

Copy of the Srophe application for British Library MSS
GNU General Public License v3.0
0 stars 2 forks source link

Update Fonts Embedded in All Srophé Apps that use Syriac #268

Open davidamichelson opened 11 months ago

davidamichelson commented 11 months ago

UPDATE WITH SOLUTION

@wsalesky Please update the following embedded fonts using fonts found here https://bethmardutho.org/resources/syriacpc/:

Change Estranglo Edessa to Estrangela Talada Revised by J.F. Coakley Change E. Syriac Adiabene to the new version of E. Syriac Adiabene Revised by J.F. Coakley Change Serto Batnan to Serto Antioch Bible 2020 Release

This change will affect the BL App, Syriaca.org App, John of Ephesus, Syriac Corpus, GEDSH, BQ Gazetteer, and Caesarea. Thanks!

For some reason, the Syriac text hangs over the left margin (but only when the window is sized a certain way, resizing the window wraps the text differently and makes the margin realign correctly. See picture from

https://bl.vuexistapps.us/browse.html?facet-classfication=Choral%20Books&

Screenshot 2023-12-15 at 2 22 51 PM

davidamichelson commented 11 months ago

This appears to be only on mac and perhaps firefox only, so maybe don't worry about it if you can't reproduce it.

davidamichelson commented 11 months ago

It must have to do with the line above characters, here is what chrome looks like

Screenshot 2023-12-15 at 2 28 06 PM

davidamichelson commented 11 months ago

Leave this until we can discuss.

davidamichelson commented 10 months ago

UPDATE WITH SOLUTION

@wsalesky Please update the following embedded fonts using fonts found here https://bethmardutho.org/resources/syriacpc/:

Change Estranglo Edessa to Estrangela Talada Revised by J.F. Coakley Change E. Syriac Adiabene to the new version of E. Syriac Adiabene Revised by J.F. Coakley Change Serto Batnan to Serto Antioch Bible 2020 Release

This change will affect the BL App, Syriaca.org App, John of Ephesus, Syriac Corpus, GEDSH, BQ Gazetteer, and Caesarea. Thanks!

wsalesky commented 10 months ago

@davidamichelson I updated the fonts, but that is not actually the issue. The Syriac font is not marked as Syriac in the text node: https://github.com/srophe/britishLibrary-data/blob/main/data/tei/78.xml#L102C38-L102C38

wsalesky commented 10 months ago

Fonts updated to all the apps.