search

ssardina-agts / agtcity-sarl-mw

The SARL middleware to for the Agents in City MAC game
GNU General Public License v3.0
1 stars 2 forks source link

Replace main branch with MW for RMIT 2018i game server #11

Closed ssardina closed 4 years ago

ssardina commented 4 years ago

This is the main objective to have in the master a MW that is fully working and clean for the RMIT game server.

This will fix #5 and #6

ayoung012 commented 4 years ago

@ssardina see PR #13 into this branch

ssardina commented 4 years ago

Have removed the dependncy on SARL_VERSION, less warnings!

Good job, it's getting cleaner.

Let's merge this version, and we keep cleaning. I want to factor out event production to a different skill. What you called Layer #3

ayoung012 commented 4 years ago

Let's keep at it! The less warnings, the better.

On Fri, 8 May 2020, 11:35 pm Sebastian Sardina, notifications@github.com wrote:

Have removed the dependncy on SARL_VERSION, less warnings!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ssardina-agts/agtcity-sarl-mw/pull/11#issuecomment-625818850, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACWYTLK3TJ4TWNAF3KMLNFLRQQDCDANCNFSM4MYM2XBQ .

ssardina commented 4 years ago

yes, let's keep reducing warnings though some are very hard to get rid. In particular I did some investigation on this type:

Possible invalid usage of 'occurrence'. The value of the feature 'occurrence' or one of its component is used as an argument of a function. This function is not marked as a pure function, i.e. without side effect. Because side effect is not allowed on 'occurrence', it may cause an unexpected or invalid running behavior. You have to ensure by yourself that the usage of 'occurrence' is valid.

@ayoung012 so what else we should do in this branch? Are we fully removing the entities here?

ayoung012 commented 4 years ago

@ssardina no I'm happy with this. Let's merge

ssardina commented 4 years ago

wait. I am doing a HUGE surgery removing all the entities. Let me see if I suceeed. It is bleeding everywhere..

ayoung012 commented 4 years ago

Ok, awesome

ayoung012 commented 4 years ago

@ssardina re the particular warning you mentioned, see '1.10. Why is an error or a warning put on the occurrence keyword?' http://www.sarl.io/docs/official/faq/SyntaxFAQ.html#1-10-why-is-an-error-or-a-warning-put-on-the-occurrence-keyword#110-why-is-an-error-or-a-warning-put-on-the-occurrence-keyword

Is it worth always assigning it to a val every time we get an occurrence just to avoid this warning?

ayoung012 commented 4 years ago

Also see http://www.sarl.io/docs/official/faq/GeneralFAQ.html#3-4-how-can-the-warnings-given-by-the-sarl-compiler-be-avoided '3.4. How can the warnings given by the SARL compiler be avoided?'

If we are to ignore warnings as a last resort we should use these specific issue codes provided.

ssardina commented 4 years ago

Yes, agree and the codes that we can use are here.

However, not every warning has a code. For example, there seems to be no code for the occurence side effet warnings

ssardina commented 4 years ago

Should we merge this? It is waiting for your review I think