search

ssardina-teaching / git-hw-submissions

Scripts to support homework submissoin via Git and GitHub
1 stars 0 forks source link

Script to create missing Feedback PRs #22

Closed AndrewPaulChester closed 3 months ago

AndrewPaulChester commented 3 months ago

As outlined in the AI24 p2 repo a current bug with GitHub Classrooms prevents the feedback PRs from being made successfully.

We need a script to check repos to see if they have it, then create it if necessary. This also means we need to create a branch at the original commit of the repo - luckily has a consistent SHA for every fork of a given project.

AndrewPaulChester commented 3 months ago

@ssardina First pass completed - note this requires the SHA to be hardcoded in BASE_SHA

ssardina commented 3 months ago

this is awesome @AndrewPaulChester , so we can run it on P2 beforehand to make sure all Feedback branches and PR are there...

ssardina commented 3 months ago

OK, I have added the SHA as argument to the script.

Now, it is not checking that the feedback PR already exists but they close it. I think we need to check for PR #1 and see if it exists, that is the one GH Classroom creates. Similar to the script I have to find closed PRs.. for example this one says it is missing but it is just closed:

https://github.com/RMIT-COSC1127-1125-AI24/p2-multiagent-K-Niva/pulls

image

AndrewPaulChester commented 3 months ago

It should not just be checking to see if they are closed, but I didn't test extensively. Perhaps it needs an argument to get any pr regardless of status? That repo is interesting because they have actually deleted the feedback branch entirely.

From: Sebastian Sardina @.> Sent: Friday, August 30, 2024 5:39:04 PM To: ssardina-teaching/git-hw-submissions @.> Cc: Andrew Chester @.>; Mention @.> Subject: Re: [ssardina-teaching/git-hw-submissions] Script to create missing Feedback PRs (Issue #22)

OK, I have added the SHA as argument to the script.

Now, it is not checking that the feedback PR already exists but they close it. I think we need to check for PR #1https://github.com/ssardina-teaching/git-hw-submissions/issues/1 and see if it exists, that is the one GH Classroom creates. Similar to the script I have to find closed PRs.. for example this one says it is missing but it is just closed:

https://github.com/RMIT-COSC1127-1125-AI24/p2-multiagent-K-Niva/pulls

image.png (view on web)https://github.com/user-attachments/assets/9095fab4-c21b-4007-bc3f-6c50473d3356

— Reply to this email directly, view it on GitHubhttps://github.com/ssardina-teaching/git-hw-submissions/issues/22#issuecomment-2320358290, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALRW5XL5RUAFRVNGZXNPPALZUAORRAVCNFSM6AAAAABNJWONQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGM2TQMRZGA. You are receiving this because you were mentioned.Message ID: @.***>

ssardina commented 3 months ago

yes I know how to improve it, I am half way no worries

ssardina commented 3 months ago

done, it can also find the merged PRs