search

ssbc / patchcore

A shared library of depject modules to build Secure Scuttlebutt social network apps
GNU Affero General Public License v3.0
74 stars 17 forks source link

Use a user's display name in their about HTML link. #76

Closed Happy0 closed 5 years ago

Happy0 commented 5 years ago

When hovering over a user's display picture, I think it's more helpful to see their display name rather than their public key. This is probably more friendly to screen readers too.

Old Version

New Version

I'll post on scuttlebutt to see if others share my opinion.

mmckegg commented 5 years ago

Not used in Patchwork, so fine by me.

In patchwork there are full hovers that show details like avatar, name, id, mutual friends, and whether you follow.

christianbundy commented 5 years ago

Nice!

I think this is a good change, the only time the ID is useful is when there are multiple feeds with the same name and photo and I'm trying to figure out which feed ID to use in Markdown. Frustrating but rare.

I think my personal preference would be name (@feedId) but I don't feel strongly about this, so if you think name-only is best then I trust your decision.

Happy0 commented 5 years ago

@christianbundy - done =]. This is what it looks like now:

New Version

Note: to use this in patchbay, we'll have to remove the /about/html/link file from patchbay while we bump patchcore (which appears to be what the patchcore version is copied from.)

Happy0 commented 5 years ago

\o/ well, if you're happy, that's good enough for me =p. We can always revert it later if anyone has objections.

Thanks for the review @christianbundy

arj03 commented 5 years ago

This is excellent, thanks @Happy0 :heart:

mixmix commented 5 years ago

Love this change!