git-link should work with magit-blame buffers

sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location

394 stars 73 forks source link

git-link should work with magit-blame buffers #60

Closed dcluna closed 5 years ago

dcluna commented 5 years ago

Hey, first of all, thanks for your work on this package, it's incredibly helpful.

So, I wrote some code to make this package return a github blame URL in case the user is in magit-blame-mode. I haven't really tried it with other hosts/handlers, but I believe it should work as-is, provided they work with commits and line numbers.

sshaw commented 5 years ago

Hi, I'm glad you find the package useful.

Thanks for the PR. I've been wanting this feature for a while! Will review.

sshaw commented 5 years ago

Closing due to lack of feedback and breaking functionality. Please feel free to reopen. This would be very nice to have.