Closed r-darwish closed 5 years ago
Hi, thanks for this nice addition. I'm excited to get it added.
When the repository is cloned via SSH the wrong URL is used. For example:
/tmp/Test >git remote -v origin s-shaw@vs-ssh.visualstudio.com:v3/s-shaw/Test/Test (fetch) origin s-shaw@vs-ssh.visualstudio.com:v3/s-shaw/Test/Test (push)
Results in:
vs-ssh.visualstudio.com/v3/s-shaw/Test/Test?path=foo.txt&version=GBmaster&line=2
Which results in a 404.
Good catch. I only checked HTTP. I'll probably need to add some kind on manipulation when the link is SSH. Could you tell me that is the HTTP URL of your repository? I think that the SSH user should replace vs-ssh
Thanks for replying quickly. I'll probably be able to commit the fixes in Sunday.
Could you tell me that is the HTTP URL of your repository? I think that the SSH user should replace vs-ssh
https://s-shaw.visualstudio.com/Test
I think that the SSH user should replace vs-ssh
Makes sense.
@sshaw I pushed a commit which normalizes the SSH links. Sorry if my elisp is horrible. This is my first non-trivial contribution for an elisp package.
Sorry if my elisp is horrible. This is my first non-trivial contribution for an elisp package.
Definitely not horrible but much appreciated.
See my latest comments. 2 other things:
Thanks!
Done 🙂
Great, thanks so much!
Hi, thanks for this nice addition. I'm excited to get it added.
When the repository is cloned via SSH the wrong URL is used. For example:
Results in:
https://vs-ssh.visualstudio.com/v3/s-shaw/Test/Test?path=foo.txt&version=GBmaster&line=2
Which results in a 404.