search

sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
394 stars 73 forks source link

[Savannah] Prevent extra "/git" appearing in M-x git-link #79

Closed leungbk closed 3 years ago

leungbk commented 3 years ago

Prior to this patch, (cadr (git-link--parse-remote remote-url)) for the Emacs repo would look like "git/emacs" instead of "emacs".

sshaw commented 3 years ago

Hi, thanks. Give me a a day or three to study this. I mean it's straightforward but the git-link--parse-remote function is getting out of control with these exception cases so just want to take a bit to look it over.

sshaw commented 3 years ago

--parse-remote definitely needs some tweaking but that's a task for another day.

The only comment I have besides the one I left inline is: while we're here shouldn't we add support for ssh://git.savannah.gnu.org/srv/git/emacs.git too?

leungbk commented 3 years ago

The only comment I have besides the one I left inline is: while we're here shouldn't we add support for ssh://git.savannah.gnu.org/srv/git/emacs.git too?

Done.

sshaw commented 3 years ago

Great thanks!