search

sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
394 stars 73 forks source link

adds service specific handlers support for git-link-homepage #87

Closed wvandeun closed 3 years ago

wvandeun commented 3 years ago

Adds support for service specific handlers for git-link-homepage. I'm not familiar with all the services, for which there are already rules for other functions. Input on those would be appreciated.

sshaw commented 3 years ago

Thanks a lot. Much needed! 💪

I'm not familiar with all the services, for which there are already rules for other functions. Input on those would be appreciated.

I say we just default to doing this if there's nothing in the alist:

(format "https://%s/%s" base (cadr remote-info))

What do you think?

It is same as the old behavior. Just having the alist is an improvement and if it doesn't work for some site(s) it can then be addressed at that time by... updating the alist.

wvandeun commented 3 years ago

Thanks a lot. Much needed! 💪

I'm not familiar with all the services, for which there are already rules for other functions. Input on those would be appreciated.

I say we just default to doing this if there's nothing in the alist:

(format "https://%s/%s" base (cadr remote-info))

What do you think?

Done, used the git-link-homepage-github handler as the default for services that are not known to me. This handler provides the desired behaviour.

sshaw commented 3 years ago

Great. Excited to have this addition 🎉

Thanks!