Open edkolev opened 2 years ago
Just did a quick check - v0.8.0
is the last working version, v0.8.1
doesn't work:
(git-link--parse-remote "gitolite@my.company.internal:dir")
;; v0.8.0 returns ("my.company.internal" "dir/")
;; v0.8.1 returns ("my.company.internal" "/")
Thanks for the info @edkolev. Bad test coverage here unfortunately 🔴
Hi, I updated the git-link package to the latest one and my custom function in "git-link-remote-alist" stopped working (produces incorrect URLs).
I've been using git-link for 3+ years without any issues with the config pasted below.
The issue is DIRNAME passed to my function is invalid. I've narrowed down the issue to
git-link--parse-remote
.Here's how to reproduce it:
This is the git config:
Could you please review the parsing in
git-link--parse-remote
? I suspect it has changed. I haven't binary-searched for the breaking commit, but it should be committed the last 1-2 years. Sorry, I don't know what was the previous version which was working for me. EDIT: last working version is in the comment below.Thanks for this package, it has been one of my daily tools!
Config ("XXX" obfuscates what I don't want to share):