search

sshaw / git-link

Emacs package to get the GitHub/Bitbucket/GitLab/... URL for a buffer location
394 stars 73 forks source link

replaces / in branch name with %2F but github URL retains the / #96

Closed bergey closed 2 years ago

bergey commented 2 years ago

At some point in the last year or two, github changed their URLs for branches with a / in their name. The slash now appears literally in the URL. The URL path that git-link generates, with %2F, resolves to a 404. git-link should avoid url-hexify in this case.

I have not checked what is needed for other git hosting providers, nor what providers git-link aims to support.

sshaw commented 2 years ago

Hi, thank you for bringing this to my attention.

If I recall PR #92 was opened to address this. Have you tried v0.8.6 or 0.8.5? Code is here.

no-response[bot] commented 2 years ago

Closing due to lack of feedback. Feel free to reopen with additional info.