search

sshnet / SSH.NET

SSH.NET is a Secure Shell (SSH) library for .NET, optimized for parallelism.
http://sshnet.github.io/SSH.NET/
MIT License
3.96k stars 931 forks source link

Remove feature binary serialization #1325

Closed scott-xu closed 6 months ago

scott-xu commented 7 months ago

The constant FEATURE_BINARY_SERIALIZATION was to help build with .NET Standard 1.3. Since current all target frameworks support Serialization, we don't need this flag anymore. See https://github.com/sshnet/SSH.NET/commit/cf8510013db0e8a1d54086d67694e041f5ef4b98?diff=split&w=0#diff-e4b38dd57f5fc1250fafcccb6ba71f914244bb03755abeea94cbfc0ea4bbbc90L44

branch scott-xu:remove-FEATURE_BINARY_SERIALIZATION is based on scott-xu:drop-RIPEMD160

scott-xu commented 7 months ago

Close this PR based on https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md Open question: can we remove [Serialization] attribute for net462? Code will be more consistency but probably no value added in practice.

Rob-Hague commented 7 months ago

I think we should keep it as it is. You can replace #if FEATURE_BINARY_SERIALIZATION with #if NETFRAMEWORK if you like.

scott-xu commented 7 months ago

Good suggestion.