DomModel.getFirstChildElementByName() does wrong thing for document nodes

sshyran / genxdm

Automatically exported from code.google.com/p/genxdm

0 stars 0 forks source link

DomModel.getFirstChildElementByName() does wrong thing for document nodes #12

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Current implementation of DomModel.getFirstChildElementByName(), for document 
nodes, calls:

document.getElementsByTagNameNS()

However, this method will walk all descendant nodes for the entire document.

a) This is slow
b) This is not the child axis

Conclusion: Implementation needs fixing.

Original issue reported on code.google.com by aale...@gmail.com on 12 Oct 2010 at 4:36

GoogleCodeExporter commented 8 years ago

I have committed a fix for the execution problem with r113.

Leaving issue open, because we need test cases that cover this mistake.

Original comment by eric%tib...@gtempaccount.com on 25 Jan 2011 at 12:10

Changed state: Started

GoogleCodeExporter commented 8 years ago

Appears to be addressed by dom adoption of bridgetest in r169 or r170.  See 
NodeNavigatorTest:139 (and probably NavigatorTest, for that matter, but I'm not 
certain of that.

DOM passes this test now.  Closing.  I wonder if the existence of a working 
test case is adequate to mark as verified?

Original comment by aale...@gmail.com on 30 Mar 2011 at 8:27

Changed state: Fixed
Added labels: Tests-Coverage

GoogleCodeExporter commented 8 years ago

The test checks what it needs to.

Original comment by eric%tib...@gtempaccount.com on 2 Apr 2011 at 12:39

Changed state: Verified

GoogleCodeExporter commented 8 years ago

Original comment by eric%tib...@gtempaccount.com on 29 Apr 2011 at 11:22

Added labels: Milestone-20110415