search

ssl-hep / ServiceX_frontend

Client access library for ServiceX
https://servicex-frontend.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
5 stars 11 forks source link

Do a preflight authentication call #520

Closed ponyisi closed 1 week ago

ponyisi commented 1 week ago

Resolves #506. Get authentication before actually doing submission, so we can raise an exception early and not hide it in the GuardList in the return value of deliver.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.09%. Comparing base (c58c5aa) to head (6144050). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #520 +/- ## ========================================== - Coverage 83.86% 83.09% -0.78% ========================================== Files 27 27 Lines 1599 1674 +75 ========================================== + Hits 1341 1391 +50 - Misses 258 283 +25 ``` | [Flag](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/520/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ssl-hep/ServiceX_frontend/pull/520/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep) | `83.09% <100.00%> (-0.78%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ssl-hep#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ponyisi commented 1 week ago

I think the codecov issue is a false positive.