search

sst / console

A web based dashboard for your SST apps
https://console.sst.dev
212 stars 21 forks source link

Fix storage of account value #5

Closed alistairstead closed 11 months ago

alistairstead commented 11 months ago

The missing key for the call to set results in each character of the accountID being stored against numerical keys in the localstorage.

This hasn't yet manifested as a problem because the * route also calls to set this value before redirecting. If you remove that logic in the route definitions this provider would not work.

Screenshot 2023-08-12 at 22 22 51
changeset-bot[bot] commented 11 months ago

⚠️ No Changeset found

Latest commit: 311d7d4594dbbd36d2edb4669306de117656864c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jayair commented 11 months ago

Oh weird

thdxr commented 11 months ago

amazing i just ran into this issue and was very confused

thank you!