search

sst / ion

SST v3
https://sst.dev
MIT License
1.88k stars 221 forks source link

GitHub Actions: `sst deploy` Step Not Failing Workflow on Deployment Error #523

Closed Rafaa17 closed 3 months ago

Rafaa17 commented 3 months ago

Hey, Trying to setup automatic deployment of sst stack using Github Actions.

Installing the sst cli script using this step

      - name: Install SST CLI
        run: curl -fsSL https://ion.sst.dev/install | bash

Then, after installing providers/dependencies, trying to deploy using

      - name: Deploy
        run: sst deploy --stage ${{ inputs.stage }}

The deploy starts progressing, but in the case of an error (i.e a role that I am trying to fetch does not exist), then the workflow finishes successfully.

I am currently catching the errors by including sst deploy as part of another script, and checking for the word "error" in the output. But I guess there should be a more native way of doing that?

thdxr commented 3 months ago

have you tried on latest? i believe we fixed this recently

thdxr commented 3 months ago

closing for now because i can't recreate it - feel free to comment if you have an issue still

Rafaa17 commented 3 months ago

@thdxr What you mean on the latest? I am installing the cli script using curl.

'''

curl -fsSL https://ion.sst.dev/install | bash

'''

Are you referring to the npm package?