search

sst / sst

Build full-stack apps on your own infrastructure.
https://sst.dev
MIT License
24.05k stars 1.85k forks source link

Fix secret set command for files #5870

Open wonathanjong opened 1 month ago

wonathanjong commented 1 month ago

The sst secret set command has a bug when reading multiline secrets from stdin (e.g., sst secret set MySecret < file.txt). The issue occurs in the stdin reading loop where reader.ReadString('\n') can return both partial content and an io.EOF error when it reaches the end of input without finding a newline character. The current code immediately breaks on io.EOF without adding the partial content to the accumulated value, causing the last line of any file without a trailing newline to be completely dropped. This affects single-line files (which get set to empty strings) and multiline files like RSA/EC private keys where the final -----END ... KEY----- line is lost, resulting in malformed secrets that cause cryptographic operations to fail with "asymmetric key" errors.

wonathanjong commented 1 month ago

@thdxr @jayair

Been banging my head against the keyboard trying to set my encryption keys as SST secrets. Please merge and release soon so I can use secrets for everything. thx

jayair commented 1 month ago

Oh thank you

wonathanjong commented 1 week ago

@thdxr could you please review and merge? this is super simple 1 line fix. It's breaking for users using SST secrets along with private public keys.