see #68: enhanced 'Binding' with varargs argument for routingKeys and…

sstone / amqp-client

[THIS PROJECT HAS BEEN ARCHIVED AND IS NO LONGER MAINTAINED] Simple fault-tolerant AMQP client written in Scala and based on Akka and the RabbitMQ java client

MIT License

161 stars 88 forks source link

see #68: enhanced 'Binding' with varargs argument for routingKeys and… #73

Open thjaeckle opened 8 years ago

thjaeckle commented 8 years ago

… bind each routingKey when processing 'AddBinding' message

sstone commented 8 years ago

I'll have a closer look asap (this weekend at the latest) but it looks good! Thanks

thjaeckle commented 8 years ago

Hi. Any news on the status of this PR? :) Do you need anything else?

sstone commented 8 years ago

Hi! Sorry it took so long, I was extremely busy on another project and fell behind. It looks ok, and I'm ready to merge. I would be nice to add a basic test, and also to port your changes to the scala2.10 branch (which I'll probably stop maintaining soon after scala 2.12 is released). I can take care of that (test + scala 2.10). Thanks!