search

st0012 / ruby-lsp-rspec

A Ruby LSP addon for RSpec tests
MIT License
127 stars 7 forks source link

Extraneous code lenses #17

Closed andyw8 closed 10 months ago

andyw8 commented 10 months ago

:wave: Not a big deal, but when trying this on https://github.com/sds/overcommit I noticed the code lenses appear on subject, and on examples within shared_examples, which seems invalid.

st0012 commented 10 months ago

Hmm are you sure it's from this addon? That's the 2 keywords that are currently not supported 🤔

andyw8 commented 10 months ago

Update after talking with Stan: The subject issue is a bug, caused by the context variable:

subject { described_class.new(config, context) }

For shared_examples, I was meaning the examples or example groups within the shared_examples, since they typically wouldn't be run directly, they would be included in another group.

st0012 commented 10 months ago

I'm not sure about shared_examples because I do run them directly from time to time (mostly too lazy to figure out the specific command to run them). I'd keep this behaviour for now unless more users complaint about it.

For the context bug, it should be fixed in #18

st0012 commented 10 months ago

@andyw8 I've cut a release for #18 too. Thanks for reporting 👍