search

stac-extensions / classification

Describes categorical values and bitfields to give values in a file a certain meaning (classification).
Apache License 2.0
11 stars 3 forks source link

add validation of MLM output using classification:classes (fixes #48) #50

Closed fmigneault closed 6 months ago

fmigneault commented 7 months ago

As proposed in #48, adds the validation of classification:classes nested under an mlm:output definition.

Adds an example demonstrating how it can be used.

~For the moment, the MLM URI validation fails inside the npm checker as it is not yet published on stac-extensions (to be discussed in the next community meeting how to make that happen). The corresponding Item (https://github.com/crim-ca/dlm-extension/blob/v1.0.0/examples/item_raster_bands.json) is however validated in using the mapping in the repository https://github.com/crim-ca/dlm-extension/blob/v1.0.0/package.json#L8-L9.~

Uses the URI defined on https://crim-ca.github.io/mlm-extension/v1.1.0/schema.json

Looking for initial feedback in case some adjustments must be done before the MLM extension is published officially.

Fixes #48

fmigneault commented 6 months ago

@m-mohr Should we wait more for feedback or can it be merged as is?

m-mohr commented 6 months ago

I think we can merge, but was just thinking that we should add a note in the Readme and a change log entry.

fmigneault commented 6 months ago

@m-mohr Added in the latest commits.

m-mohr commented 6 months ago

@m-mohr Added in the latest commits.

Thanks. With regards to the README, I think it should be mentioned here: https://github.com/stac-extensions/classification/pull/50/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R44-R51

Otherwise it's not clear from the README directly that it can be used in MLM.

fmigneault commented 6 months ago

@m-mohr Added in c10239a

m-mohr commented 6 months ago

Thanks.