search

stachenov / quazip

Qt/C++ wrapper over minizip
Other
582 stars 232 forks source link

Possibility to build without QTextCodec #151

Closed xlazom00 closed 8 months ago

xlazom00 commented 2 years ago

I would like to propose idea that we can build quazip without QTextCodec.

as in Qt6 QTextCodec is deprecated

And there is also option to add support for QStringDecoder I found this QStringDecoder vs QTextCodec

xlazom00 commented 2 years ago

So something like this? https://github.com/Memsource/quazip/pull/1/files

oblivioncth commented 2 years ago

Qt 6.4 is enabling QStringConverter to use any encoding provided by ICU when Qt is built with ICU support enabled.

https://doc-snapshots.qt.io/qt6-dev/whatsnew64.html https://doc-snapshots.qt.io/qt6-dev/qstringconverter.html#encodingForName

In the long run this is probably the preferred alternative for handling encodings that were previously deprecated by Qt6, rather than a manual switch like the above (though they can certainly coexist). Build Qt with ICU support, get extended encoding support in QuaZip.

This would allow dropping the Qt5Compat module as a requirement when using Qt6 outright.

cen1 commented 8 months ago

Closing in favor of a more recent https://github.com/stachenov/quazip/issues/184