stackabletech / hive-operator

Other
21 stars 1 forks source link

Use patched version of op-rs that hopefully addresses SUP-148. #544

Closed soenkeliebau closed 4 days ago

soenkeliebau commented 1 week ago

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated
sbernauer commented 2 days ago

I'm currently reviewing the back-port in https://github.com/stackabletech/hive-operator/pull/545 and I'm a bit confused, is it correct that this did not change a single line of code? ^^

siegfriedweber commented 2 days ago

I'm currently reviewing the back-port in #545 and I'm a bit confused, is it correct that this did not change a single line of code? ^^

The actual work is done in stackable-operator. The function definition did not change there. So, if an operator just used this function then upgrading stackable-operator was sufficient. If an operator tried to calculate the ServiceAccount name on its own, then changes were necessary.

sbernauer commented 2 days ago

Awesome, many thanks! I already assumed so, just wanted to be sure