search

stackbuilders / dotenv-hs

Load environment variables from dotenv files for Haskell
https://hackage.haskell.org/package/dotenv
MIT License
65 stars 14 forks source link

Added upper limits of required dependencies #176

Closed DanRCM closed 11 months ago

DanRCM commented 1 year ago

174

Issue 1: 'ghc-options: -O2' is rarely needed: Time tests were conducted using time cabal build, yielding the following results: Without using "-O2": image

With the use of "-O2": image

From these results, we can see that the use of "-O2" doesn't actually provide any time-related benefits.

Issue 2: Missing Upper Bounds in Dependency Packages Upper bounds were added to the dependencies that required them: "-compat -containers -directory -hspec -shellwords -text". The gen-bounds tool was used, as suggested. Tests were conducted via stack to assess the compatibility of each of the packages with the upper bounds I set, based on the proposed suggestions using the gen-bounds tool."

CristhianMotoche commented 1 year ago

Thank you so much for your contribution @DanRCM LGTM!

CristhianMotoche commented 1 year ago

@DanRCM Let's specify the boundaries of the common dependencies only in the library section. The boundaries will be automatically inherited to the other sections.

DanRCM commented 1 year ago

@CristhianMotoche Hi, thanks for your recommendation, the changes have been made.

CristhianMotoche commented 1 year ago

Hello @DanRCM Thanks for addressing the suggestions. It seems something in the recent changes has caused issues when building the package. I think you need to lower the boundaries for text.

CristhianMotoche commented 1 year ago

Hello @DanRCM Do you need any help on this PR?

DanRCM commented 1 year ago

Hello @DanRCM Do you need any help on this PR?

Hello, excuse me, I have been really busy, but I'll continue working in your project, thank you for your help, I'll do the changues inmediately

DanRCM commented 1 year ago

Hello @CristhianMotoche the changes have been made, I have been taking your advices to lower the text boundaries.

DanRCM commented 11 months ago

@CristhianMotoche Hello, could you tell me what you suspect about what could be giving me problems with the PR? I need help

CristhianMotoche commented 11 months ago

Hello @DanRCM It seems there are some issues with the changed boundaries. Let me double check your PR locally and I'll keep you posted.

DanRCM commented 11 months ago

Hello @DanRCM It seems there are some issues with the changed boundaries. Let me double check your PR locally and I'll keep you posted.

ok, thanks for keeping me in mind, it's a pleasure

CristhianMotoche commented 11 months ago

@all-contributors please add @DanRCM for code

allcontributors[bot] commented 11 months ago

@CristhianMotoche

I've put up a pull request to add @DanRCM! :tada: