onUserSessionEnd and onDocumentSessionEnd never get called

stackiva / slate-collaborate-support

0 stars 0 forks source link

onUserSessionEnd and onDocumentSessionEnd never get called #16

Closed PaddyMann closed 3 years ago

PaddyMann commented 3 years ago

Expected behavior:

onUserSessionEnd gets called after closing a web browser with a document editor open
onDocumentSessionEnd gets called after closing all web browsers with document editors open

Neither seem to get called at all.

wleroux commented 3 years ago

Will look into this soon.

wleroux commented 3 years ago

Resolved the issue in 0.0.14.

There is still a related issue that will be resolved in #3 however. When a service is terminated while subscriptions still exist, the new services (or other service nodes) are not aware that the session is defunc and will not call the onUserSessionEnd and onDocumentSessionEnd API calls. As part of the larger work involved in #3, this will be resolved.