Add logging for update fails

stacklok / frizbee

Throw a tag at it and it comes back with a checksum.

Apache License 2.0

87 stars 21 forks source link

Add logging for update fails #140

Open amouat opened 5 months ago

amouat commented 5 months ago

At the moment it seems Frizbee will just fail silently if it can't get a digest e.g. because of auth or network issues. I think it would be worth logging this to stderr.

For example:

FROM redis:invalid_image_tag

is clearly an image reference, but will just be ignored.

I guess this is the place in the code?

https://github.com/stacklok/frizbee/blob/main/pkg/replacer/replacer.go#L303

rdimitrov commented 5 months ago

hey, @amouat 👋 Thanks for reaching out!

You're right, logging that message might be handy 👍 Feel free to open a PR in case you already have one 😃

blkt commented 1 month ago

Hi @amouat I'm reaching out to check if this is still relevant to you. We gladly accept contributions that improve the user experience, so feel free to open a PR if you want!

amouat commented 1 month ago

I still think it makes sense, yes.

I'm not actively using frizbee right now, so I don't have a PR.