Closed ninjadev64 closed 1 year ago
Please solve these :
It would also be nice to either make all of the commits build successfully you can do that by either : rebasing and x commit into y commit or do it by rewriting the history with interactive rebasing
Please solve these :
These linter violations are not caused by my code.
It would also be nice to either make all of the commits build successfully you can do that by either : rebasing and x commit into y commit or do it by rewriting the history with interactive rebasing
A little bit unnecessary, no?
It would also be nice to either make all of the commits build successfully you can do that by either : rebasing and x commit into y commit or do it by rewriting the history with interactive rebasing
A little bit unnecessary, no?
Do you really want to merge an unclean history into main?????
Do you really want to merge an unclean history into main?????
It's not like main has a 100% clean track record, but stackotter should squash this PR before merging anyway.
It would also be nice to either make all of the commits build successfully you can do that by either : rebasing and x commit into y commit or do it by rewriting the history with interactive rebasing
A little bit unnecessary, no?
Do you really want to merge an unclean history into main?????
It's not like main has a 100% clean track record, but stackotter should squash this PR before merging anyway.
this makes it all even worse, god damn I give up
@InfRandomness it is nice to have a clean commit history on main, I agree. However, I don't want to force contributors to rebase cause not everyone knows how to, so I usually just squash merge if the commits don't obviously need to be separate. Mostly PRs are pretty small so it's not sacrificing too much commit granularity.
Description
This PR creates a CustomJSONDecoder struct, which wraps around the ZippyJSONDecoder and JSONDecoder
decode
method depending on platform. ZippyJSONDecoder is used on all platforms except Linux, where it is not currently supported.Additionally, this PR replaces swift-concurrency with swift-atomics, which builds on Linux. Thanks to LeoDog896 for originally making this change.
This should warrant an update to #113.
Type of change
Checklist: