stackotter / delta-client

An open source Minecraft Java Edition client built for speed.
https://deltaclient.app
GNU General Public License v3.0
313 stars 33 forks source link

Make RenderCoordinator errors recoverable #190

Closed jandrokt closed 2 months ago

jandrokt commented 2 months ago

Description

This pull request ensures that any errors that may surge in RenderCoordinator#init are propagated back to the UI and so that an error message is shown instead of crashing the entire client.

Fixes #175 (not sure if fully)

Type of change

Please delete options that are not relevant.

Checklist:

mattg42 commented 2 months ago

Any reason why RendererError is a struct with a separate error kind enum property, instead of just being an enum itself?

stackotter commented 2 months ago

Any reason why RendererError is a struct with a separate error kind enum property, instead of just being an enum itself?

Hahah didn't see this until after I submitted my review, you beat me to it

stackotter commented 2 months ago

I'll wait for the workflows to complete.